Skip to content

Add Edits From NPD Repo #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Merge Dev into Main
merged 5 commits into from
Oct 23, 2025
Merged

Add Edits From NPD Repo #343

merged 5 commits into from
Oct 23, 2025

Conversation

@IsaacMilarky
Copy link
Collaborator

Add Edits From NPD Repo

Problem

Currently, we have issues with our contributors.yml workflow. We also do not have a default .gitleaks.toml file template that we include in the repositories that are generated.

Solution

In the contributors.yml file, use a personal access token in the checkout action to make sure that we are using a user that has push access to main. This way we can circumvent branch protections for the action.

Also, added a .gitleaks.toml file to all tiers as well as this repository. This file includes gitleaks regex patterns for common keys. It can and should be configured for different project types.

sachin-panayil
sachin-panayil approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@sachin-panayil sachin-panayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

natalialuzuriaga
natalialuzuriaga requested changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving the secrets variable error, this should be good to go!

Another question: does the .gitleaks.toml file have to live in the root directory? Could this be moved to the .github directory?

@natalialuzuriaga natalialuzuriaga changed the base branch from main to dev September 23, 2025 20:47
decause-gov
decause-gov approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@decause-gov decause-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 🚢

This blocking on anything else?

@IsaacMilarky
Copy link
Collaborator Author

After resolving the secrets variable error, this should be good to go!

Another question: does the .gitleaks.toml file have to live in the root directory? Could this be moved to the .github directory?

Sounds good! I have updated the raw tag problem finally. As for the .gitleaks.toml question, we could move it into the .github directory however we would have to configure gitleaks to look for the file in that location explicitly.

I have amended the gitleaks workflow to look for the config in that location and moved the files accordingly.

natalialuzuriaga
natalialuzuriaga approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all is working!! LGTM 🙌

@natalialuzuriaga
Copy link
Collaborator

After resolving the secrets variable error, this should be good to go!
Another question: does the .gitleaks.toml file have to live in the root directory? Could this be moved to the .github directory?

Sounds good! I have updated the raw tag problem finally. As for the .gitleaks.toml question, we could move it into the .github directory however we would have to configure gitleaks to look for the file in that location explicitly.

I have amended the gitleaks workflow to look for the config in that location and moved the files accordingly.

Super clutch, thank you!

@natalialuzuriaga natalialuzuriaga merged commit def63c3 into dev Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natalialuzuriaga natalialuzuriaga natalialuzuriaga approved these changes

@sachin-panayil sachin-panayil sachin-panayil approved these changes

@decause-gov decause-gov decause-gov approved these changes

@DinneK DinneK Awaiting requested review from DinneK

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IsaacMilarky @natalialuzuriaga @sachin-panayil @decause-gov